Skip to content

Query builder canvas check#3

Merged
mdroidian merged 2 commits intomainfrom
query-builder-canvas-check
Feb 11, 2026
Merged

Query builder canvas check#3
mdroidian merged 2 commits intomainfrom
query-builder-canvas-check

Conversation

@mdroidian
Copy link
Copy Markdown
Contributor

@mdroidian mdroidian commented Feb 11, 2026


Open with Devin

Summary by CodeRabbit

  • Bug Fixes

    • Prevented multiple canvases from mounting on the same page. The application now detects existing canvas instances and conflicts, displaying warning notifications to users with recommendations for resolution.
  • Chores

    • Updated development build configuration to automatically manage output files.
    • Updated project .gitignore file.

- Introduced a new plugin in the dev script to copy the built extension files (JavaScript and CSS) from the dist directory to the project root. This allows for easier development and testing by ensuring that the root files are always up-to-date with the latest builds.
…lay warning toast

- Added logic to detect existing canvas instances by class and ID, preventing conflicts.
- Implemented a warning toast notification when multiple canvases are detected, advising users to disable conflicting extensions for optimal performance.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 11, 2026

Walkthrough

This pull request introduces three interconnected changes: a .gitignore entry for extension.css, a custom esbuild plugin in the dev script that copies compiled files (extension.js and extension.css) from the dist directory to the root directory after successful builds, and logic in the Tldraw component to detect and prevent multiple canvas instances from mounting on the same page while displaying user warnings when conflicts are detected.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Query builder canvas check' directly reflects the main change: adding logic to detect and prevent multiple canvases from mounting when the Query Builder owns the canvas, including warning toasts for user feedback.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch query-builder-canvas-check

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@mdroidian mdroidian merged commit 5b53963 into main Feb 11, 2026
1 of 2 checks passed
@mdroidian mdroidian deleted the query-builder-canvas-check branch February 11, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant